Martin Kealey

Results 295 comments of Martin Kealey

@pickeduname I've created pull request #296 on your behalf. The commit uses email address reply+AABQFBOB7ABFJCZ2ZEYB4VF6R7QF3EVBNHHDHKJGJI@reply.github.com which is the reply-to address for this issue, however it would be preferable to use...

@pickeduname I can't memo or privmsg you on freenode as your nicks aren't registered and you seem to be offline. There's a [#revolutionirc](ircs://chat.freenode.net:6697/revolutionirc) channel on freenode if you're not already...

@pickeduname I've redone the patch to omit some obviously inadvertent changes * in `app/build.gradle` * changed quote marks on line 11 (`versionName`) * in `app/src/main/res/layout/activity_edit_ignore_entry.xml` * swap lines 73,74 *...

@pickeduname I will amend the patch to conform to the coding style for this project, in particular: * include a space after a keyword that requires a following open parenthesis:...

I remain concerned about the impact on existing users of changing from Glob to Regex; perhaps that could be mitigated by allowing both: * regex when enclosed in a pair...

I'm afraid my frustrations are creeping in and I'm refactoring as I go, rather than just making minimal changes. I'm not qualified to comment on the _Unsupported Modules Detected_ problem....

I've just had a night's sleep and almost finished rebuilding my machine so that I have a working JDK. I'll push my changes once I've confirmed an error-free build. These...

Footnote: When I'm editing code I tend to refactor fairly strongly, rather than just making minimal changes (Seeing a long chain of member selectors and array-indexings gratuitously repeated just makes...

If I've "stolen your thunder" or otherwise detracted from your efforts then I do apologize. When I said "c'est la vie", I meant that since your contributions obviously take precedence,...