SierraBreezeEnhanced icon indicating copy to clipboard operation
SierraBreezeEnhanced copied to clipboard

GNOME decorations hover should not use a gradient

Open codic12 opened this issue 4 years ago • 19 comments

The latest Adwaita version does not use a gradient when you hover over a button.

codic12 avatar Apr 03 '20 19:04 codic12

I heard about that, it seems this #21 does not apply anymore :(

I think there is some screenshot in some other issue, I'll try to find it

kupiqu avatar Apr 03 '20 19:04 kupiqu

Oh, it's actually in #65

kupiqu avatar Apr 03 '20 19:04 kupiqu

Ah ok ;)

codic12 avatar Apr 03 '20 19:04 codic12

Yup image Adwaita was updated for a more flat look :D

codic12 avatar Apr 03 '20 19:04 codic12

I guess it makes sense to change it if Gnome/Adwaita style users prefer it this way. Would you like to give it a try? It shouldn't be too difficult to change it

kupiqu avatar Apr 03 '20 19:04 kupiqu

Sure! Where would I find the relevant files?

codic12 avatar Apr 03 '20 19:04 codic12

It's all in drawIconGnome function in breezebutton.cpp

kupiqu avatar Apr 03 '20 19:04 kupiqu

Hm, I don't know C++. I'll take a look and see what I can do though

codic12 avatar Apr 03 '20 20:04 codic12

Hm, I don't know C++. I'll take a look and see what I can do though

I don't think you need much C++ knowledge for this purpose, give it a try :-)

kupiqu avatar Apr 03 '20 20:04 kupiqu

I'm assuming you can just remove all the gradient references? And then paint the standard color object instead of a gradient object?

codic12 avatar Apr 03 '20 20:04 codic12

Yes, just that. I recommend that you make changes one by one and check it on the fly.

And then you can consider whether buttons should be surrounded by circles or squares according to Adwaita...

kupiqu avatar Apr 03 '20 20:04 kupiqu

Also, wondering whether we should keep previous Gnome style for those who like it, hmm, even though under a different name...

EDIT: but don't worry about it... it won't be difficult to have it back if someone requests it

kupiqu avatar Apr 03 '20 20:04 kupiqu

Why not call this one adwaita and the old one 'old adwaita'?

Oh, ok

codic12 avatar Apr 03 '20 20:04 codic12

Why not call this one adwaita and the old one 'old adwaita'?

Oh, ok

Sure, I am all for it, didn't want to give you too much trouble ;-)

kupiqu avatar Apr 03 '20 20:04 kupiqu

:P I have a school assignment to do;I'll give it a shot after!

codic12 avatar Apr 03 '20 20:04 codic12

Sure, no hurries

kupiqu avatar Apr 03 '20 20:04 kupiqu

got sidetracked. I cannot figure it out :(

codic12 avatar Apr 03 '20 20:04 codic12

Ok, no problem

kupiqu avatar Apr 04 '20 14:04 kupiqu

My aim is that SBE is maintained by the community. This shouldn't be hard to fix. I hope someone in the community cares about SBE and submits a pull request about it... I could help if somebody wants to try but is lost where to start.

kupiqu avatar Nov 01 '21 09:11 kupiqu