GeoIP icon indicating copy to clipboard operation
GeoIP copied to clipboard

support nodejs 6.x (update nan, use node-gyp)

Open dankang opened this issue 9 years ago • 6 comments

  • update nan version (2.1.0 => 2.3.5)
  • use node-gyp instead of pangyp(deprecated)
  • tested on nodejs 4.4.5 & 6.2.2

dankang avatar Jun 22 '16 02:06 dankang

@kuno Right now, I can only check Travis CI build results. If you give me the access permission for AppVeyor, Wercker.. I will fix build failure.

dankang avatar Jun 22 '16 02:06 dankang

@kuno is there any chance to get this merged? There are multiple security issues in the pangyp dependencies since it is deprecated.

fmasuhr avatar Jul 19 '16 15:07 fmasuhr

+1

chetverikov avatar Aug 09 '16 06:08 chetverikov

node v6 has moved into active LTS mode and a lot of people can't upgrade their projects (myself included) because we have a dependency on this package. This PR really needs to be rolled in at least to make it possible to upgrade.

diversario avatar Nov 08 '16 21:11 diversario

@kuno - what is the status on this ?. We have an urgent need to have this mergerd due to nsp checks

 minimatch   2.0.10      >=3.0.2                      [email protected] > [email protected] > [email protected] > [email protected] > [email protected]   https://nodesecurity.io/advisories/118 
 minimatch   2.0.10      >=3.0.2                      [email protected] > [email protected] > [email protected] > [email protected]                https://nodesecurity.io/advisories/118 

luigizuccarelli avatar Nov 16 '16 10:11 luigizuccarelli

I needed this so I created @captemulation/[email protected]

CaptEmulation avatar Apr 25 '18 21:04 CaptEmulation