Insights Code scanning report

[RenierLewis]

Hi

Thank you for your great work with this bundle and your contribution to the open source community.

I have put the bundle through Sensiolabs Insights code scanning and just wanted to share the findings with you.

The scanning found 5 Major bugs all related to direct use of the session object, and 1 minor issue.

They are: PHP super globals should never be used (5) - MajorBugrisk in src/Dropbox/Store/SessionPersistentDataStore.php, line 33 if (isset($_SESSION[$this->prefix . $key])) { $_SESSION super global should not be used.

similiarly in src/Dropbox/Store/SessionPersistentDataStore.php, line 34 in src/Dropbox/Store/SessionPersistentDataStore.php, line 49 in src/Dropbox/Store/SessionPersistentDataStore.php, line 61 in src/Dropbox/Store/SessionPersistentDataStore.php, line 62

For more info see https://insight.sensiolabs.com/what-we-analyse/symfony.use_super_globals

User specific files should not appear in .gitignore MinorCodestyle in .gitignore, line 5 /.idea /.idea is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

For more info see https://insight.sensiolabs.com/what-we-analyse/git.user_specific_ignored_file

If possible for you to fix these issue with a future commit, it will be appreciated.

Kind Regards Renier Lewis