Kunal Tyagi

Results 187 comments of Kunal Tyagi

> If there are no points selected, then no callback is fired? Then we can simply remove the code dealing with checking if some points have been selected. Would simplify...

@janekT Please remove the `.DS*` binary files (from history)

Setting milestone to 1.12 since it deprecates, and let's not add deprecation in a minor release

`PointPickingCallback::performAreaPick` changes the API. Do we consider that an an internal API? If yes, then this creates a ABI change (due to std::vector -> std::map in the AreaPick class). If...

Functional casts aren't limited to `static_cast` and can call `dynamic_cast`. Ofc, this is ok for integral parameters, but for other types, this can unknowingly involve runtime penalty. Making the rule...

> We will have to see how difficult it is to integrate that into the SupervoxelClustering class @tanismar Internally, the heavy lifting is performed by OcTree and KDTrees. You could...

@tanismar if it works, please report back and we can add that as a PR :)