IntelliJBehave icon indicating copy to clipboard operation
IntelliJBehave copied to clipboard

Lexer from Arnauld & Module Dependency scope from me

Open witspirit opened this issue 11 years ago • 4 comments

Hi Aman,

I recently stumbled on your IntelliJBehave plugin and found it very helpful. However, in my project setup I experienced some issues regarding sluggishness and in some cases steps failed to be found.

To overcome these issues I modified your plugin to search for steps in the module containing the story file and the module dependencies.

In addition we used some story syntax that was not handled properly by your current lexer and parser. I found another github user, arnauld, had already done quite some work in creating a new lexer/parser (not sure, but he seems the lead on the Eclipse JBehave plugin) and merged that in.

If you are still interested in persueing this plugin, I propose you consider pulling in the changes I already aggregated and perhaps you could release a new version in the JetBrains repository.

If, however, you are no longer interested in following up on this plugin, I would like to know whether it would be ok for me to publish a new version in the JetBrains repository with proper attribution.

Kind regards,

Bert Van Vlerken (https://github.com/witspirit)

witspirit avatar Feb 01 '13 16:02 witspirit

Hi Bert, First of all, I would like to thank you (+Arnauld+jarosite) for your work and contributions to this project.

Now, can you go ahead and publish this new version (under a new name) to the Plugin Repository? I believe if you publish under a new name, include the license and proper attribution, we should be "fine". Correct me if I'm wrong.

Atif

atifmansoor avatar Mar 14 '13 18:03 atifmansoor

Hi Atif,

Thanks for getting back to me.

If you no longer seek to update the plugin, I'd be happy to prepare a version to publish under a new name, with proper attribution and license. Thanks for your advice on the matter.

Thanks again for getting this plugin started.

Cheers,

Bert

On Thu, Mar 14, 2013 at 7:47 PM, Atif Mansoor [email protected]:

Hi Bert, First of all, I would like to thank you (+Arnauld+jarosite) for your work and contributions to this project.

Now, can you go ahead and publish this new version (under a new name) to the Plugin Repository? I believe if you publish under a new name, include the license and proper attribution, we should be "fine". Correct me if I'm wrong.

Atif

— Reply to this email directly or view it on GitHubhttps://github.com/kumaraman21/IntelliJBehave/pull/24#issuecomment-14921603 .

witspirit avatar Mar 14 '13 21:03 witspirit

Bert, you have confused me with the original author. I am not kumaraman21, lol

atifmansoor avatar Mar 14 '13 22:03 atifmansoor

Oops :-) You are right, I confused you with the original author, sorry about that. Still thanks for your contributions !

Nonetheless, I'll consider doing as you advised.

Kind regards,

Bert

On Thu, Mar 14, 2013 at 11:51 PM, Atif Mansoor [email protected]:

Bert, you have confused me with the original author. I am not kumaraman21, lol

— Reply to this email directly or view it on GitHubhttps://github.com/kumaraman21/IntelliJBehave/pull/24#issuecomment-14934363 .

witspirit avatar Mar 15 '13 08:03 witspirit