Abhishek Kumar

Results 66 comments of Abhishek Kumar

> This changeset enables hiding / showing mnemonics on `JMenuBar` only. Do you plan to update `ButtonUI` and `LabelUI` for GTK Look-and-Feel too? Not as a part of this PR....

@aivanov-jdk Imports are expanded and sorted as per recent review comments. I guess everything is fine now.

> The diff modifies the generic `SynthGraphicsUtils.paintText` so that no mnemonic is passed to `SwingUtilities2.drawStringUnderlineCharAt` if `isMnemonicHidden` returns `true`. > > This approach has _a performance impact_ on all UI...

Adding a brief details for the changes in PR as it got multiple commits and will be hard to track those changes. Initial proposed fix was to handle the **mnemonic...

/summary Hides mnemonics on menus, buttons, and labels for GTK L&F. Moved shared code for hiding mnemonics into `sun/swing/MnemonicHandler` and `AltProcessor` to avoid code duplication.

> > @kumarabhi006 Setting summary to: > > It's not what I meant. This summary will be included in the commit message, its purpose is to provide additional details of...

/summary Hides mnemonics on menus, buttons, and labels for GTK L&F. Moved shared code for hiding mnemonics into sun/swing/MnemonicHandler and AltProcessor to avoid code duplication.

> This looks like it is much better than the first iteration and being able to unify some code is good. The change looks "big" but seems to be mostly...

> I am not sure about the statement above. I think the check should take care of the direction, which is -1 in your case I think the check is...

> @mrserb The code you added also affects WORD and SENTENCE cases. I suggest covering those with a test as well. Yes, that affects the WORD and SENTENCE cases. I...