kuma icon indicating copy to clipboard operation
kuma copied to clipboard

MeshProxyPatch error does not help debugging the issue

Open slonka opened this issue 3 years ago • 14 comments

What happened?

Error like this:

# [proxytemplates.kuma.io](http://proxytemplates.kuma.io/) "test-abc" was not valid:
# * spec.conf.modifications[1].httpFilter.value: native Envoy resource is not valid: invalid character 'a' in literal null (expecting 'u')

Does not help fixing the issue. Maybe this could be improved. The error message seems to come from jsonpb - not sure if we can do anything about this.

Side note: reported via slack.

slonka avatar Aug 09 '22 05:08 slonka

Triage: ideally we would like to have more descriptive message with diff and place that is wrong. If we cannot do this in a reasonable time add "troubleshooting" in ProxyTemplate docs.

jakubdyszkiewicz avatar Aug 16 '22 14:08 jakubdyszkiewicz

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Nov 15 '22 08:11 github-actions[bot]

@jakubdyszkiewicz how's this in MeshPorxyPatch?

lahabana avatar Jan 24 '23 11:01 lahabana

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Apr 25 '23 07:04 github-actions[bot]

I think we should check if it's better with MeshProxyPatch. If it is we should address this in MeshProxyPatch, if it isn't we should just close this issue

lahabana avatar Apr 25 '23 10:04 lahabana

Triage: it's the same with MeshProxyPatch

jakubdyszkiewicz avatar May 09 '23 15:05 jakubdyszkiewicz

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Aug 08 '23 07:08 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Nov 08 '23 07:11 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Feb 08 '24 07:02 github-actions[bot]

@lahabana - as stated by @jakubdyszkiewicz it's the same in MeshProxyPatch - please prioritise this if you still think it's relevant

slonka avatar Feb 09 '24 14:02 slonka

Hi @slonka,

I'm still using my work-around to cope with https://github.com/kumahq/kuma/issues/4720, which is okay for the time being. For my understanding the adoptions of https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/ will fundamentally resolve my issues related the handling of graceful shutdown. I'd rather wait for this than to encourage you spending further effort in resolving the issue within the current setup.

zd9KgA avatar Feb 11 '24 20:02 zd9KgA

Hi @zd9KgA - I linked to the wrong comment, this issue is unrelated. Yes https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/ - will resolve the issues.

slonka avatar Feb 13 '24 08:02 slonka