kuma
kuma copied to clipboard
kumahq
Kuma release tags don't match Go module versioning
Summary
The Kuma release tags don't work correctly with Go module versioning, making it difficult to write code that uses the Kuma API.
Steps To Reproduce
Importing the unversioned API module:
jpeach@greenling:/tmp/k$ go get github.com/kumahq/kuma/api
go: downloading github.com/kumahq/kuma/api v0.0.0-20210531143733-0079cdb82767
go get: added github.com/kumahq/kuma/api v0.0.0-20210531143733-0079cdb82767
Importing a release tag:
jpeach@greenling:/tmp/k$ go get github.com/kumahq/kuma/[email protected]
go: downloading github.com/kumahq/kuma/api v0.0.0-20210513090738-be98608a8344
go get: downgraded github.com/kumahq/kuma/api v0.0.0-20210531143733-0079cdb82767 => v0.0.0-20210513090738-be98608a8344
The modfile doesn't understand what the version is:
jpeach@greenling:/tmp/k$ cat go.mod
module k
go 1.16
require (
github.com/kumahq/kuma/api v0.0.0-20210513090738-be98608a8344 // indirect
google.golang.org/grpc v1.37.1 // indirect
)
I'm pretty sure that versioning the API module would work right if the version tag was "v1.1.6". There's more problems if you try to import anything ffrom github.com/kumahq/kuma due to the rewriting, but that's a different issue IIUC.
Ref https://golang.org/doc/modules/version-numbers
Reopening since 1.2.0 wasn't tagged with a leading v.
cc @nickolaev @jakubdyszkiewicz
Reopening. @jakubdyszkiewicz tried to tag 1.2.1 with the v prefix but had to back it out after running into some issues with the nested modules.
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@michaelbeaumont @jakubdyszkiewicz is this now possible? It would be nice for the next release to have correct tagging.
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.
I believe all the automation has been done for this work now without changing the internal version inside Kuma. We should try it out.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.
Automation is in a much better state. We may be able to do this now as things are contained in release.sh now.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.