kuma-website icon indicating copy to clipboard operation
kuma-website copied to clipboard

Dependabot seems to be unable to create PRs for vulnerable dependencies

Open slonka opened this issue 2 years ago • 15 comments

Issue edited (original content below)

What happened?

Our GH dependabot seem to be unable to open PRs to fix vulnerable dependencies: https://github.com/kumahq/kuma-website/security/dependabot

This might be due to dependencies having exact version requirement.

Need to investigate and fix this.


~~Our GH security advisories / dependabot updates seem to be not working.~~

~~When going to https://github.com/kumahq/kuma-website/security/advisories we don't see any security advisories listed, but running yarn audit shows vulnerabilities:~~

yarn audit

...
99 vulnerabilities found - Packages audited: 1544
Severity: 2 Low | 33 Moderate | 56 High | 8 Critical

~~We need to fix this and have an automatic update mechanism just like in Kuma.~~

slonka avatar Aug 03 '22 09:08 slonka

https://github.com/kumahq/kuma-website/security/dependabot

michaelbeaumont avatar Aug 03 '22 09:08 michaelbeaumont

Security advisories are thing that are manually written and released by us

michaelbeaumont avatar Aug 03 '22 09:08 michaelbeaumont

I don't have access (404 not found). Even if it's listed there should be a dependabot update PR for each of this, right?

slonka avatar Aug 03 '22 09:08 slonka

Potentially, but dependabot can't update every dependency if it's not compatible with the constraints we have.

michaelbeaumont avatar Aug 03 '22 09:08 michaelbeaumont

Buggy behavior from dependabot here? Looking at https://github.com/kumahq/kuma-website/security/dependabot/47 we see that 4.1.0 is vulnerable, which is in yarn.lock. But we see "No security update is needed as ansi-regex is no longer vulnerable." However, in the logs:

updater | INFO <job_433101476> Checking if ansi-regex 2.1.1 needs updating
  proxy | 2022/08/03 10:03:37 [016] GET https://registry.npmjs.org:443/ansi-regex
  proxy | 2022/08/03 10:03:38 [016] 200 https://registry.npmjs.org:443/ansi-regex
  proxy | 2022/08/03 10:03:38 [018] GET https://registry.npmjs.org:443/ansi-regex/6.0.1
  proxy | 2022/08/03 10:03:38 [018] 200 https://registry.npmjs.org:443/ansi-regex/6.0.1
updater | INFO <job_433101476> Latest version is 6.0.1
updater | INFO <job_433101476> no security update needed as ansi-regex is no longer vulnerable
updater | INFO <job_433101476> Finished job processing
updater | INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | time="2022-08-03T10:03:38Z" level=info msg="task complete" container_id=job-433101476-updater exit_code=0 

But we're apparently nevertheless using 4.1.0 and not using 6.0.1 at all, so this doesn't seem right.

michaelbeaumont avatar Aug 03 '22 10:08 michaelbeaumont

Triage: there is a problem with dependabot configuration https://github.com/kumahq/kuma-website/network/updates We think that current dependabot PRs are security updates from Github.

jakubdyszkiewicz avatar Aug 08 '22 14:08 jakubdyszkiewicz

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Jan 30 '23 08:01 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar May 01 '23 08:05 github-actions[bot]

Should we use our security update github action for this repo as well? I'm putting this back to triage to discuss with the team.

slonka avatar May 02 '23 10:05 slonka

Triage: still the case. Let's try this with dependabot. Our security update tool may not work with Ruby

jakubdyszkiewicz avatar May 15 '23 14:05 jakubdyszkiewicz

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Aug 14 '23 08:08 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Nov 17 '23 08:11 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Feb 16 '24 08:02 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar May 20 '24 08:05 github-actions[bot]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. If you think this issue is still relevant, please comment on it or attend the next triage meeting.

github-actions[bot] avatar Aug 19 '24 08:08 github-actions[bot]