kuma-gui icon indicating copy to clipboard operation
kuma-gui copied to clipboard

chore: remove unused CSS and fonts, add fonts we use

Open johncowen opened this issue 8 months ago • 1 comments

Following on from https://github.com/kumahq/kuma-gui/pull/3689 I had another quick review of our global CSS and found a few more things we could remove there.

Interestingly I also found out (from what I could see) that we ship the Fira Mono but we don't seem to use it anywhere? Whereas @kong/design-tokens tokens use JetBrainsMono (kui-font-family-code) but we don't ship that even though we say some of our fonts should use it if its available (it has fallbacks, but still). Honestly I find it a little weird that @kong/design-tokens doesn't ship the fonts it uses, even if they wanted that to be optional, but 🤷

I removed Fira Mono and added JetBrainsMono from here https://github.com/JetBrains/JetBrainsMono

johncowen avatar Apr 02 '25 12:04 johncowen

Deploy Preview for kuma-gui ready!

Name Link
Latest commit e1492489c17764964058c7a7e5593cd7044ca1f4
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/67ed32fea5d1b5000855bd6c
Deploy Preview https://deploy-preview-3732--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 02 '25 12:04 netlify[bot]

💯 there should be tokens for typography

btw there are tokens for typography, but they don't ship the fonts that they define in the tokens 🤷 , even so you could pull them in optionally (or use google fonts)

johncowen avatar Apr 04 '25 14:04 johncowen