kuma-gui icon indicating copy to clipboard operation
kuma-gui copied to clipboard

chore: Remove RouterLink from globals, its replaced by XAction

Open johncowen opened this issue 1 year ago • 1 comments

Replaces all remaining instances of RouterLink with XAction, then removes RouterLink from eslint globals.

Note: RouterLink is still available for use, its just harder to use.


Replaces all remaining instances of KButton with XAction. XAction uses KButton under-the-hood


Why:

XAction is one single component for "let the user click this to perform an action". Engineers don't need to think about whether it should be a button, an anchor, a RouterLink, a KButton or something else and occasionally make the wrong choice. Just use XAction and all will be good.

XAction also comes with extra functionality to easily be able to update URL query strings with boolean ?active to mean active=true.

https://github.com/kumahq/kuma-gui/pull/2273


Lastly I've been waiting for a good time to do this (i.e. I don't have another bunch of potentially conflicting PRs up), and now felt like a good time to do it.

johncowen avatar Sep 05 '24 11:09 johncowen

Deploy Preview for kuma-gui ready!

Name Link
Latest commit ec8997c8a74e3e686cffeef497d940a6ad19c313
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/67221a7edbdacf0008879961
Deploy Preview https://deploy-preview-2873--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 05 '24 11:09 netlify[bot]