kuma-gui icon indicating copy to clipboard operation
kuma-gui copied to clipboard

page highlighting doesn't seem to work

Open johncowen opened this issue 1 year ago • 1 comments

What happened?

When clicking to page 2 I see this:

Screenshot 2024-07-22 at 10 43 39

Note the highlighted page 2 button

Whereas when I click on page 14 I see this:

Screenshot 2024-07-22 at 10 45 00

Note the page 14 button is not hightlighted.

I think there might be some other minor UX issues with the stepped pagination also.


We use KPagination via AppCollection > KTable > KPagination and we always set the current page correctly at an application level via AppCollection:

https://github.com/kumahq/kuma-gui/blob/23a5bd95b875b9dec9d3ab14552548f40f7bc370/src/app/data-planes/views/DataPlaneListView.vue#L42

So we need to check our configuration of KTable/KPagination to make sure that is correct, otherwise the issue is possibly further in.

johncowen avatar Jul 22 '24 09:07 johncowen

See https://github.com/Kong/kongponents/pull/2307

johncowen avatar Jul 29 '24 08:07 johncowen

Fixed via https://github.com/Kong/kongponents/pull/2307

johncowen avatar Sep 02 '24 13:09 johncowen