kuma-gui icon indicating copy to clipboard operation
kuma-gui copied to clipboard

Published 20 hours ago • verified publisher icon kumahq

feat(zones): move KDSSubscriptions to use a table/summary

Open johncowen opened this issue 1 year ago • 3 comments

Changes Zone Subscriptions only to use a table/summary view/interaction.

We decided that there would be far more space to show things if we used our common table/summary panel pattern instead of the accordion where there is very little space to show things:

Screenshot 2024-06-20 at 12 37 34

Screenshot 2024-06-20 at 12 37 44

See:

  • https://github.com/kumahq/kuma-gui/issues/2623
  • https://github.com/kumahq/kuma-gui/issues/2164

~Questions:~

~1. Do we want to show the Subscription YAML, the Subscription JSON config, or both?~ ~2. If we want to show both, should we add a separate [YAML] tab or use the Structured/YAML dropdown?~

Note:

I'm guessing we'll want the same layout for DPP subscriptions, I plan to do this as a follow up and there will some changes made on top of here to make the panel work in both places.

Closes https://github.com/kumahq/kuma-gui/issues/2704

johncowen avatar Jun 20 '24 11:06 johncowen

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 77aaf2b2efd3619d8f63723d91a91255b3ce8c7c
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/66e163b3fb018e0007df7e06
Deploy Preview https://deploy-preview-2664--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 20 '24 11:06 netlify[bot]

  1. Do we want to show the Subscription YAML, the Subscription JSON config, or both?
  2. If we want to show both, should we add a separate [YAML] tab or use the Structured/YAML dropdown?

I figured we probably don't want to show the YAML, its not like you'd want to use it for anything. If that incorrect we can always add as a follow up.

johncowen avatar Jun 26 '24 12:06 johncowen

K this one has had a few alterations after a first round of reviews, good to go again now 👍

johncowen avatar Jul 31 '24 10:07 johncowen

LGTM do we have issues to cover the same work for dataplane and zone proxies? If not can we open them and milestone them for 2.10 please?

lahabana avatar Sep 12 '24 13:09 lahabana

👍 Added these two:

  • https://github.com/kumahq/kuma-gui/issues/2920
  • https://github.com/kumahq/kuma-gui/issues/2921

johncowen avatar Sep 12 '24 16:09 johncowen