kuma-gui icon indicating copy to clipboard operation
kuma-gui copied to clipboard

chore: expands make usage with the more commonly used targets

Open johncowen opened this issue 9 months ago • 1 comments

Back in https://github.com/kumahq/kuma-gui/pull/2457 we added a very minimal Makefile based on kuma's and we plan on using this going forwards to give us a thin layer/abstraction over our various utility commands scripts.

This PR adds the minimal/commonly used targets so we can get used to using make as early as possible:

  • installing (make install)
  • running a dev server (make run)
  • testing (make test/unit and make test/e2e)
  • linting (make lint)

I've combined installing with running the dev server as installing it now super quick compared to yarn, but I'm not totally sure whether we would inadvertently update the lock file every so often with that. We'll see as we move forwards.

I've added some extra help to get started by way of basic node version checking and "escape hatch" type run/% which calls the corresponding package script so we don't have to have a make equivalent for every single package script, only the common ones. make help should be enough for folks to figure out how to get started.

I've continued to use include files given that we will have to inject different functionality depending on the environment. Idea being you will just need to use make install wherever you are and things should "Just Work(tm)"

Lastly, I updated our DEVELOPER.md to match and cleaned up our package scripts slightly and removed the scripts we don't no longer need.

Part of https://github.com/kumahq/kuma-gui/issues/1448

johncowen avatar Apr 30 '24 16:04 johncowen

Deploy Preview for kuma-gui ready!

Name Link
Latest commit 3e2cd375648b82906e4352870f96c52f6d7ab222
Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/663a5242e36b520008016146
Deploy Preview https://deploy-preview-2529--kuma-gui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 30 '24 16:04 netlify[bot]