Deepak Kumar

Results 28 issues of Deepak Kumar

Currently some of the examples use deprecated calls. These examples are supposed to be used by users as samples, so, these need to be inline with best practices that DC...

dc-v5

This is not getting covered as part of #1736. It will be taken care of later as a separate activity as it needs some discussions: - `curve`, `interpolate` and `tension`...

dc-v5

It seems Composite carts rely on adjusting margins which are used directly by the children. Need to investigate further.

dc-v5

The current API allows these to be updated. The documentation warns against that. Charts are lilely to be messed up if someone does set these. We should make these read-only...

dc-v5

Usage of JS SPA frameworks like Angular and React are gaining momentum. I know dc has already been used in such environments. Since we will be refactoring this library for...

dc-v5

The document (http://dc-js.github.io/dc.js/docs/html/LineChart.html#xyTipsOn__anchor) suggests that `xyTipsOn` has no effect if brush in on. The document also suggests that it is `boolean`. However, the code supports a special value 'always' https://github.com/dc-js/dc.js/blob/82469c9c9cdc27bdca1d5b1b4f1e8ac79c41f9d9/src/charts/line-chart.js#L353...

dc-v5

Currently, legend instance call functions in the chart instance. This works, however, it is inconsistent. Sometimes the chart instance is accessed as the _parent and sometimes as `chart` member in...

dc-v5

`_doColumnHeaderFnToString` (https://github.com/dc-js/dc.js/blob/develop/src/charts/data-table.js#L92) is quite fragile. https://github.com/dc-js/dc.js/blob/82469c9c9cdc27bdca1d5b1b4f1e8ac79c41f9d9/src/charts/data-table.js#L92-L107 It is there to maintain backward compatibility in the `columns` argument. Currently, the chart supports three different ways (http://dc-js.github.io/dc.js/docs/html/DataTable.html#columns__anchor) to specify columns. I think...

dc-v5

Currently, the API documentation (http://dc-js.github.io/dc.js/docs/html/LineChart.html#dashStyle__anchor) suggests it to be an array of numbers. However, the see also link https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray suggests it to be a `string`. It currently works because when...

dc-v5