react-bulma icon indicating copy to clipboard operation
react-bulma copied to clipboard

Feature/add columns component

Open dotamir opened this issue 7 years ago • 9 comments

dotamir avatar Dec 18 '17 14:12 dotamir

I've just made the basics. It will be complete, And please left your comments and lemme know what you think and what is your idea? Let's work together on this.

dotamir avatar Dec 18 '17 14:12 dotamir

I am really hopeful for this to get added but I think some changes could be made. The text alignment can always be passed in as a className so it just adds overhead to the api and documentation. Also I think having the gap and multiline props would be nice

skbolton avatar Dec 27 '17 17:12 skbolton

@skbolton Yeah, I'm with you. And I've deleted the text alignments. Also, I'll commit the new changes.

dotamir avatar Dec 27 '17 17:12 dotamir

I think to match the api elsewhere the is part of the props should be dropped so

<Columns multiline gapless>
  <Column is={2}>
    <h1>Hey there</h1>
  </Column>
</Columns>

instead of

<Columns isMultiline isGapless>
  <Column is="is-2">
    <h1>Hey there</h1>
  </Column>
</Columns>
  

skbolton avatar Jan 03 '18 20:01 skbolton

@skbolton Can you do that? I just busy right now.

dotamir avatar Jan 10 '18 15:01 dotamir

Yeah I can get it

skbolton avatar Jan 13 '18 18:01 skbolton

@kulakowka Let's work on it together. What's your idea about it until here? gimme a feedback and I'll complete this.

dotamir avatar May 08 '18 11:05 dotamir

Do you have some news about the Columns feature progress ? :)

scorsi avatar Sep 16 '18 17:09 scorsi

This feature is important, will be fixed and merged?

juanbrujo avatar Sep 02 '20 17:09 juanbrujo