AbstractOperators.jl icon indicating copy to clipboard operation
AbstractOperators.jl copied to clipboard

Improve test coverage, fix remove_slicing, remove mul_skipZeros! of VCAT

Open hakkelt opened this issue 1 month ago • 2 comments

Things get fixed:

  • GitHub actions start Julia with a single thread by default, but it disabled many tests for multithreaded branches. This got fixed in ci.yaml
  • VCAT and Compose had low code coverage, so I extended the tests. During that time, I discovered some issues with remove_slicing that I fixed.
  • I removed the non-exported function mul_skipZeros! because it is not covered with tests and does not appear to be used anywhere (including StructuredOptimization.jl).
  • BroadCast and GetIndex received minor fixes, and the latter was also formatted.

hakkelt avatar Nov 11 '25 15:11 hakkelt

Codecov Report

:x: Patch coverage is 94.52055% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.89%. Comparing base (c8e2903) to head (c1d3de1). :warning: Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/linearoperators/GetIndex.jl 96.03% 4 Missing :warning:
src/utils.jl 83.33% 2 Missing :warning:
src/calculus/Compose.jl 87.50% 1 Missing :warning:
src/calculus/VCAT.jl 94.73% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #28       +/-   ##
===========================================
+ Coverage   72.66%   85.89%   +13.22%     
===========================================
  Files          44       45        +1     
  Lines        3077     3063       -14     
===========================================
+ Hits         2236     2631      +395     
+ Misses        841      432      -409     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 11 '25 17:11 codecov[bot]

This PR is also ready for merging. @nantonel @lostella: Can you confirm that mul_skipZeros! from VCAT is safe to remove?

hakkelt avatar Nov 11 '25 21:11 hakkelt