SideMenu icon indicating copy to clipboard operation
SideMenu copied to clipboard

fixed frame change on in-call status bar

Open bonyadmitr opened this issue 6 years ago • 2 comments

it is better to implement logic on UIApplication.willChangeStatusBarFrameNotification notification for good animation, but it will take lots changes for frames. this one is hot fix and will change frame at the end of status bar animation.

It can be tested in simulator by Hardware - Toggle in-call Status bar

Screen Shot 2020-02-07 at 13 43 28

bonyadmitr avatar Feb 07 '20 10:02 bonyadmitr

@bonyadmitr Thanks for your PR. How could I reproduce this case? Using "Toggle in-call Status bar" doesn't seem to trigger the function call?

kukushi avatar Feb 08 '20 09:02 kukushi

@bonyadmitr Thanks for your PR. How could I reproduce this case? Using "Toggle in-call Status bar" doesn't seem to trigger the function call?

I'm a little bit confused. It should be called. didChangeStatusBarFrameNotification observer must be called. I fixed a bug in my project by this observer.

bonyadmitr avatar Feb 08 '20 14:02 bonyadmitr