openapi-schema-pydantic icon indicating copy to clipboard operation
openapi-schema-pydantic copied to clipboard

Still maintained?

Open mike-oakley opened this issue 1 year ago • 3 comments

There doesn't seem to have been any activity on this repo for a while @kuimono - are you still able to maintain it? I'd be happy to help or take it on if not

mike-oakley avatar May 10 '23 12:05 mike-oakley

It looks like you've already started: https://github.com/mike-oakley/openapi-pydantic

Your version might replace the original project, but a couple of things would help:

  • The README should say it's derived from openapi-schema-pydantic 1.2.4, making its origins clear.
  • It's confusing that the version number dropped to 0.2.2. Can it go back to 1.x?
  • You could consider adding a CONTRIBUTING.md .

hathawsh avatar Jul 03 '23 17:07 hathawsh

Hi @hathawsh - yep indeed i've forked and updated the project. Happy to accept contributions there - if @kuimono does want to pick this back up i'd also be happy to merge back into this original (however I have started to make some perhaps opinionated decisions).

Re your points:

  • The README credits section and the License file do both give credit to this original implementation, however I'll update the README to mention earlier and with a specific version where the fork occurred.
  • The version number went to 0.x as part of my fork and updates (which made some changes to this original). Will look to cut a 1.x release once it has a little more use. I started versioning afresh to keep things simple for newcomers but appreciate its a little odd coming from this lib.
  • Will add a contribution guide asap 👍🏼

mike-oakley avatar Jul 04 '23 08:07 mike-oakley

Looks good! Thanks for the updates to your project.

hathawsh avatar Jul 05 '23 15:07 hathawsh