mat-datetimepicker icon indicating copy to clipboard operation
mat-datetimepicker copied to clipboard

Published 20 hours ago • verified publisher icon kuhnroyal

Support for Luxon

Open wakonp opened this issue 4 years ago • 2 comments

Hey guys, I really appreciate your work and would like to contribute to your project with this little script.

https://gist.github.com/wakonp/e714ccd3384c16becf124e06216be0f3

Maybe you can add the support for Luxon. The DateTimeAdapter uses the same Options provided in this library https://github.com/andreialecu/ngx-material-luxon

wakonp avatar Apr 11 '21 22:04 wakonp

this looks interesting indeed! i will take a look at it..

bbortt avatar Apr 14 '21 16:04 bbortt

hi @wakonp, I finally found time to look at your adapter. I've never heard of luxon, but looked it up and it sounds great. the code looks fine to me in general, why don't you want to submit a PR yourself? from what I see..

  • [ ] this requires a second subproject (you can roughly copy @mat-datetimepicker/moment),
  • [ ] the formats are missing,
  • [ ] an example must be added (src/app/luxon, copy from src/app/moment as well)
  • [ ] and an additional section in README.md.
  • [ ] you'd also have to include the new module in some scripts for publishing (package.json, .github/workflows).

I can help you out if you have any questions, of course. but for now I myself will rather be focused on the ~40 remaining but reports..

bbortt avatar Dec 30 '21 20:12 bbortt