George Fu comments

Results 216 comments of


                                            George Fu

When SDK introduces client side rate limiting in default RetryStrategy, the error is swallowed

I don't think we need to implement anything here. A retry token is a concept that we don't require customers to know about, so adding it to an error message...

Ability to log version from SDK Client

We should extract the version from package.json and put it in the client.config. Preferably the extraction would also avoid importing the entirety of the package.json object.

SSMClient unable to fetch secrets while running in Next.js middleware

The AWS SDK's browser vs Node.js differentiation is done at compile time using package.json metadata for bundlers. The SDK does not attempt to recognize what environment it is in at...

TypeScript - mark response properties required if they're guaranteed to be present

Our recommendation is to use one of the type transforms from `@smithy/types`. https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-smithy-types/ ```ts import { S3 } from "@aws-sdk/client-s3"; import type { AssertiveClient, UncheckedClient } from "@smithy/types"; const s3a...

TypeScript - mark response properties required if they're guaranteed to be present

We can make a request to our documentation writer teammates to add a link to the supplemental developer-written docs. @RanVaknin please open a ticket. Our default types have `| undefined`...

'@smithy/node-http-handler' not included in lambda Node.js 20.x runtime

> The bundled SDK is provided as a convenience for developers building simpler functions or using the Lambda console for development https://docs.aws.amazon.com/lambda/latest/operatorguide/sdks-functions.html The AWS Lambda provided AWS SDK for JavaScript...