kuttl icon indicating copy to clipboard operation
kuttl copied to clipboard
verified publisher icon kudobuilder

manifest envsubst

Open so-jelly opened this issue 4 years ago • 6 comments

What this PR does / why we need it:

This PR replaces variable references in manifests with environment variables. It also adds the generated pet name to the environment so that it can be templated as well.

Fixes # https://github.com/kudobuilder/kuttl/issues/203

so-jelly avatar Oct 25 '21 23:10 so-jelly

Thanks for the contribution... We need a sign-off on the DCO to move forward

kensipe avatar Feb 13 '22 14:02 kensipe

thanks @so-jelly for this contrib! It would very much helm me with asserting cluster-wide resources dynamically instanciated by a kuttl and referencing the associated $NAMESPACE.

Any chance for you to proceed with the DCO signature so that this feature can be merged,, such as running git rebase --signoff HEAD~2 ?

gberche-orange avatar Oct 27 '22 13:10 gberche-orange

@so-jelly can you rebase and add DCO - happy to see this change comes in ;)

haarchri avatar Jan 07 '23 10:01 haarchri

I refactored to remove that licensed code. Some edge cases i considered is variables in GVK and keys. I have thought through this a bit and I think it is sound. I can add some test cases as well.

so-jelly avatar Jan 23 '23 17:01 so-jelly

I created test cases for some additional field entries. I am not sure what is up with Github review requests. tagging @kensipe in case the review request isn't sufficient.

so-jelly avatar Jan 27 '23 20:01 so-jelly

@jaypipes I can provide details elsewhere... I'm just seeing this. looks urgent and apologies for being out of pocket... for way too long. I will review today/night and respond and/or merge

kensipe avatar Jun 26 '23 17:06 kensipe