minesweeper

minesweeper copied to clipboard

Often the corner divs were neglected from calculating bombs

1

For instance finding a bomb on bottom div needs a condition i

Thamjith

0xflotus

Off by one error on app.js, line 54 & 152

3

The code-block containing the line 152 is as follows: ``` if (currentId < 89) { const newId = squares[parseInt(currentId) +width].id //const newId = parseInt(currentId) +width ....refactor const newSquare = document.getElementById(newId)...

onurbal101

Something wrong at counting the bombs in the last 9 squares

1


am-chourasia

Remove hanging brackets that cause error, simplify checkSquare function

1

- Hanging brackets on the last line of app.js causes an error, simply removed to correct. - Simplify the checkSquare function by removing the "square" parameter as it isn't used...

AustinMallar

https://github.com/kubowania/minesweeper/blob/bb3641fcb5c85918b8bd1594f397342e4ec223a3/app.js#L105 ``` const newSquare = document.getElementById(newId) click(newSquare) ``` it can come ones at the end of the function instead in every if block

yanai101

Use right-click as additional flag creator created functions for edge-checking Simplified `checkSquare()` Removed `shuffledArray` since `Array.sort()` is an inline operation.

Naxos84