Jakub Žádník

Would it be possible to add a test for it? We already have some tests for completions.

I haven't worked on completions myself, so I can't provide a concrete advice, but you can look at `nu-cli/tests/completions.rs`. You could e.g. create a new alias completer that starts with...

The parser/AST side is the same, but in this one, I'm going smarter about it and added an ID field to Span, then later I'll remove its start/end fields and...

+1 for renaming things and making them constant. Just note that files can be modules as well, not just scripts, and modules are not evaluated, only parsed. So this should...

I think it is a good change to remove auto-globbing from variables and string interpolations. Also agreed that we can get rid of `str glob-escape`. I'm just not sold on...

Seems like this simple implementation should be enough to recover from most error states for two reasons: 1. `EngineState` is in most cases modified by the “delta” approach, first recording...

Actually, there are some init steps before running the actual REPL `loop` which would get re-run on the reset. From the top of my head, the side effects would be...

One approach Sophia suggested was to only wrap the `loop` part of the REPL and the init would be wrapped separately. That way, we'd land in the last known engine...

I believe that `register` of an unknown plugin talks to the binary during parsing to generate the signature and save it to the plugin file. And `nu-highlight` is calling the...

I like the promise of the PR, though I don't really understand the implementation since I've never worked on the plugins code. One thing that jumped at me is that...