kubeadmiral icon indicating copy to clipboard operation
kubeadmiral copied to clipboard

feat: add informer-manager and federated-informer-manager readyz checks

Open z1cheng opened this issue 1 year ago • 3 comments

Add informer-manager and federated-informer-manager readyz checks

close #272

z1cheng avatar Nov 17 '23 11:11 z1cheng

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e653c57) 28.63% compared to head (56372f9) 28.63%. Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   28.63%   28.63%           
=======================================
  Files         114      114           
  Lines       13565    13565           
=======================================
  Hits         3885     3885           
  Misses       9296     9296           
  Partials      384      384           
Flag Coverage Δ
unittests 28.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 03:11 codecov[bot]

/lgtm /assign @gary-lgy Pls keep the code rebased. :)

Poor12 avatar Nov 28 '23 03:11 Poor12

@Poor12 Thanks for your review! But @gary-lgy proposed an enhancement, see the comment: https://github.com/kubewharf/kubeadmiral/issues/272#issuecomment-1818152972

I will try to implement the proposal.

/hold

z1cheng avatar Nov 28 '23 10:11 z1cheng