katalyst-core icon indicating copy to clipboard operation
katalyst-core copied to clipboard

feat: support shared_cores overlap reclaimed_cores

Open cheney-lin opened this issue 1 year ago • 1 comments
trafficstars

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

cheney-lin avatar Apr 30 '24 07:04 cheney-lin

Codecov Report

Attention: Patch coverage is 82.84024% with 87 lines in your changes missing coverage. Please review.

Project coverage is 56.19%. Comparing base (8c5f5f2) to head (b56fa5b). Report is 2 commits behind head on main.

:exclamation: Current head b56fa5b differs from pull request most recent head 0b77b4e

Please upload reports for the commit 0b77b4e to get more accurate results.

Files Patch % Lines
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 58.62% 18 Missing and 6 partials :warning:
...pu/assembler/headroomassembler/assembler_common.go 78.02% 12 Missing and 8 partials :warning:
pkg/agent/sysadvisor/metacache/metacache.go 27.77% 10 Missing and 3 partials :warning:
...u/assembler/provisionassembler/assembler_common.go 91.20% 6 Missing and 5 partials :warning:
...n/qosaware/resource/cpu/isolation/isolator_load.go 44.44% 2 Missing and 3 partials :warning:
...st-agent/app/options/sysadvisor/sysadvisor_base.go 70.00% 3 Missing :warning:
...plugin/qosaware/resource/cpu/region/region_base.go 87.50% 2 Missing :warning:
pkg/agent/sysadvisor/types/helper.go 90.00% 1 Missing and 1 partial :warning:
pkg/util/general/common.go 81.81% 2 Missing :warning:
pkg/util/general/deepcopy.go 71.42% 1 Missing and 1 partial :warning:
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   56.06%   56.19%   +0.13%     
==========================================
  Files         535      535              
  Lines       49871    50105     +234     
==========================================
+ Hits        27961    28159     +198     
- Misses      18341    18385      +44     
+ Partials     3569     3561       -8     
Flag Coverage Δ
unittest 56.19% <82.84%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 07:04 codecov[bot]