katalyst-core icon indicating copy to clipboard operation
katalyst-core copied to clipboard

support share cores with numa binding

Open nightmeng opened this issue 10 months ago • 2 comments

What type of PR is this?

Features

What this PR does / why we need it:

Support share cores with NUMA binding

Which issue(s) this PR fixes:

Special notes for your reviewer:

nightmeng avatar Apr 19 '24 08:04 nightmeng

Codecov Report

Attention: Patch coverage is 76.01810% with 53 lines in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (3a0e668) to head (53bec7b).

Files Patch % Lines
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 55.55% 18 Missing and 6 partials :warning:
pkg/agent/sysadvisor/metacache/metacache.go 27.77% 10 Missing and 3 partials :warning:
...u/assembler/provisionassembler/assembler_common.go 92.10% 3 Missing and 3 partials :warning:
...n/qosaware/resource/cpu/isolation/isolator_load.go 44.44% 2 Missing and 3 partials :warning:
...st-agent/app/options/sysadvisor/sysadvisor_base.go 70.00% 3 Missing :warning:
...in/inference/modelresultfetcher/borwein/borwein.go 0.00% 0 Missing and 1 partial :warning:
pkg/agent/sysadvisor/plugin/metacache/metacache.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   56.51%   56.45%   -0.07%     
==========================================
  Files         543      544       +1     
  Lines       50984    51117     +133     
==========================================
+ Hits        28815    28857      +42     
- Misses      18500    18597      +97     
+ Partials     3669     3663       -6     
Flag Coverage Δ
unittest 56.45% <76.01%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 19 '24 08:04 codecov[bot]

what's the difference between this pr and https://github.com/kubewharf/katalyst-core/pull/481 ?

waynepeking348 avatar May 06 '24 02:05 waynepeking348