kubewarden-controller icon indicating copy to clipboard operation
kubewarden-controller copied to clipboard

Published 20 hours ago • verified publisher icon kubewarden

Domain-qualified finalizer names

Open jvanz opened this issue 10 months ago • 3 comments

When ran the integration tests we see this warning messages:

  2024-04-19T14:43:33-03:00     INFO    KubeAPIWarningLogger    metadata.finalizers: "integration-tests-safety-net-finalizer": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
  2024-04-19T14:43:33-03:00     INFO    KubeAPIWarningLogger    metadata.finalizers: "kubewarden": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

We should address that to follow the best practices.

Acceptance criteria

  • Use domain-qualified finalizer names
  • Ensure that tests are passing
  • Ensure the upgrade path is passing

jvanz avatar Apr 19 '24 17:04 jvanz

I would add this one to 1.13, given we're doing quite some cleanups inside of the controller. At least everything will be tested at the same time.

What do the other @kubewarden/kubewarden-developers think about that?

flavio avatar Apr 22 '24 12:04 flavio

I would add this one to 1.13, given we're doing quite some cleanups inside of the controller. At least everything will be tested at the same time.

What do the other @kubewarden/kubewarden-developers think about that?

Fine by me

jvanz avatar Apr 22 '24 13:04 jvanz

Fine by me too. Added to milestone.

viccuad avatar Apr 25 '24 07:04 viccuad