user-guide icon indicating copy to clipboard operation
user-guide copied to clipboard

docs, net-binding-plugins: Fix links

Open EdDev opened this issue 9 months ago • 6 comments

What this PR does / why we need it:

Fix links in the documentation of the network binding plugins.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE

EdDev avatar May 02 '24 09:05 EdDev

/lgtm btw I hit these while changing all xrefs for #794 (there's also a (#register) xref in both of these files that are in the same boat). If/when that merges it becomes moot but it makes sense to merge this in the interim. Thanks for the fix!

aburdenthehand avatar May 03 '24 13:05 aburdenthehand

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar May 28 '24 09:05 kubevirt-bot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Aug 26 '24 09:08 kubevirt-bot

Pull requests that are marked with lgtm should receive a review from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

kubevirt-bot avatar Sep 23 '24 14:09 kubevirt-bot

@kubevirt-bot: The label(s) needs-approver-review cannot be applied, because the repository doesn't have them.

In response to this:

Pull requests that are marked with lgtm should receive a review from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Sep 23 '24 14:09 kubevirt-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Oct 02 '24 10:10 kubevirt-bot