user-guide
user-guide copied to clipboard
kubevirt
Remove extra "=" on virtctl_client_tool user_guide
What this PR does / why we need it: There is a typo on the virtctl Client Tool installation, this extra "=" is leading users to an error when trying to install virtctl.
galmeida@VAN-932852-LT0:~/kubevirt-gitops$ export VERSION==$(curl https://storage.googleapis.com/kubevirt-prow/release/kubevirt/kubevirt/stable.txt)
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 7 100 7 0 0 89 0 --:--:-- --:--:-- --:--:-- 89
galmeida@VAN-932852-LT0:~/kubevirt-gitops$ wget https://github.com/kubevirt/kubevirt/releases/download/${VERSION}/virtctl-${VERSION}-linux-amd64
--2024-04-25 11:24:35-- https://github.com/kubevirt/kubevirt/releases/download/=v1.2.0/virtctl-=v1.2.0-linux-amd64
Resolving github.com (github.com)... 140.82.114.4
Connecting to github.com (github.com)|140.82.114.4|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-04-25 11:24:36 ERROR 404: Not Found.
galmeida@VAN-932852-LT0:~/kubevirt-gitops$ echo $VERSION
=v1.2.0
E.g. Expected --> v1.2.0 Actual result --> =v1.2.0
Special notes for your reviewer: This is my first PR, sorry about any mistakes.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rmohr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @gcezaralmeida. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dhiller: Closed this PR.
In response to this:
/close
Done with https://github.com/kubevirt/user-guide/pull/803
Sorry @gcezaralmeida saw this one later only ! Thanks for your contribution anyway! :pray:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.