user-guide
user-guide copied to clipboard
kubevirt
Fix wrong link and typo
What this PR does / why we need it: Change / Fix / Add feature for documentation
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): No Issue fix
Fixes #
Special notes for your reviewer: I think we need to change all the oc command in the documentation, to be more agnostic. If some specificities in Openshift, either create each time if necessary a dedicated chapter or push it outside the kubevirt. Because you ask to try with the quickstart but we can't use the oc command.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [x] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [x] Code: Write code that humans can understand and Keep it simple
- [x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [x] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [] Community: Announcement to kubevirt-dev was considered
Release note:
Hi @Davidffry. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thanks @Davidffry PR makes sense and special notes too. Any reason to keep this as a draft? /approve
Thanks @Davidffry PR makes sense and special notes too. Any reason to keep this as a draft?
No really reason, but re-read I view, in the header, that there is a note with this "By deploying KubeVirt on top of OpenShift the user can benefit from the OpenShift Template functionality."
maybe change into kind : "Only on Openshift Cluster"
There is no Template CRD in Kubevirt/Kubernetes deployment. Only Openshift.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Davidffry Thanks for the contribution!
Can you rebase and address Andrew's comment?
Thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabiand, jean-edouard
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [fabiand,jean-edouard]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale