project-infra
project-infra copied to clipboard
kubevirt
lint: enable all standard linters on project-infra
Is your feature request related to a problem? Please describe: As a follow up to https://github.com/kubevirt/project-infra/issues/3822 we want to enable the golangci-lint rules that have been disabled in the PR https://github.com/kubevirt/project-infra/pull/3825 that integrated the linter but disabled the default linters: https://github.com/dhiller/project-infra/blob/22defd18943880ba3aa05fa11bfeb7203c545774/.golangci.yaml#L6-L14
Describe the solution you'd like:
Goals/Linters to enable:
- [ ] staticcheck
- [ ] unused
- [ ] ineffassign
- [ ] govet
- [ ] gosimple
- [ ] errcheck
- [ ] gocyclo with setting: min-complexity: 10 (default is 30)
- [ ] remove all
//nolintdirectives
Describe alternatives you've considered:
Additional context:
@dhiller: This request has been marked as needing help from a contributor.
Guidelines
- No Barrier to Entry
- Clear Task
- Solution Explained
- Provides Context
- Identifies Relevant Code
- Gives Examples
- Ready to Test
- Goldilocks priority
- Up-To-Date
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/kind cleanup /wg code-quality /help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.