project-infra
project-infra copied to clipboard
kubevirt
governance,community: add job to remove inactive users
What this PR does / why we need it:
Adds a job to remove inactive users from the community.
It first runs the contributions generator from k/community, then modifies the orgs.yaml with the result, and lastly generates a PR with the changed file.
Example PR: https://github.com/kubevirt/project-infra/pull/3999
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Successful test run (no people removed from the org): https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-community-remove-inactive-users-from-orgs-yaml/1868698001782870016
Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.
After that period the bot marks them with the label needs-approver-review.
/label needs-approver-review
Hey, just a quick heads up that this PR is still waiting to be reviewed, maybe you can take a look @EdDev @vladikr ? Thank you
I'm sorry. I missed this somehow. I'm all for it. However, I would prefer to send a warning before the removal. What do you think? Would this be possible?
I'm sorry. I missed this somehow. I'm all for it. However, I would prefer to send a warning before the removal. What do you think? Would this be possible?
@vladikr I am not sure about that being necessary - they are being pinged inside the PR description and can then complain on this PR.
OTOH I see your point, maybe it would be a good middle ground updating the PR description with a kinder message, i.e. something that refers to the member requirements section i.e.
The users pinged in this PR have shown no activity over an extended period of time, which is required and defined by our membership policy.
They are therefore removed from the KubeVirt GitHub organization.
Any KubeVirt GitHub organization member that believes they are removed without a valid reason can veto on this PR against their removal by adding a comment and pinging one of the KubeVirt project maintainers.
WDYT?
I'm sorry. I missed this somehow. I'm all for it. However, I would prefer to send a warning before the removal. What do you think? Would this be possible?
@vladikr I am not sure about that being necessary - they are being pinged inside the PR description and can then complain on this PR.
OTOH I see your point, maybe it would be a good middle ground updating the PR description with a kinder message, i.e. something that refers to the member requirements section i.e.
The users pinged in this PR have shown no activity over an extended period of time, which is required and defined by our membership policy. They are therefore removed from the KubeVirt GitHub organization. Any KubeVirt GitHub organization member that believes they are removed without a valid reason can veto on this PR against their removal by adding a comment and pinging one of the KubeVirt project maintainers.
WDYT?
@dhiller Ok, I think it's fine. In this case, we just need to make sure that we don't merge these PRs too fast, to allow people some time to respond.
I'm sorry. I missed this somehow. I'm all for it. However, I would prefer to send a warning before the removal. What do you think? Would this be possible?
@vladikr I am not sure about that being necessary - they are being pinged inside the PR description and can then complain on this PR.
OTOH I see your point, maybe it would be a good middle ground updating the PR description with a kinder message, i.e. something that refers to the member requirements section i.e.
The users pinged in this PR have shown no activity over an extended period of time, which is required and defined by our membership policy. They are therefore removed from the KubeVirt GitHub organization. Any KubeVirt GitHub organization member that believes they are removed without a valid reason can veto on this PR against their removal by adding a comment and pinging one of the KubeVirt project maintainers.
WDYT?
@dhiller Ok, I think it's fine. In this case, we just need to make sure that we don't merge these PRs too fast, to allow people some time to respond.
@vladikr I agree - how about we merge the removal PR after a period of one week?
@dhiller Ok, I think it's fine. In this case, we just need to make sure that we don't merge these PRs too fast, to allow people some time to respond.
@vladikr I agree - how about we merge the removal PR after a period of one week?
+1 I think this is a good time frame.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhiller
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dhiller]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:
- key
community-periodics.yamlusing filegithub/ci/prow-deploy/files/jobs/kubevirt/community/community-periodics.yaml
In response to this:
What this PR does / why we need it:
Adds a job to remove inactive users from the community.
What it does:
- it runs the contributions generator from k/community
- on repo k/project-infra it then modifies the orgs.yaml with the result, effectively removing the inactive users from the org and all teams, and generates a PR with the changed file
- on repo k/community it adds all inactive users to the alumni.yaml, then runs the generator to update the alumni markdown file, and generates a PR with the changed file
Example PRs:
- kubevirt/project-infra#3999
- kubevirt/community#405
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.