project-infra
project-infra copied to clipboard
kubevirt
community: add test, lint and coverage jobs
What this PR does / why we need it:
Based on PR https://github.com/kubevirt/community/pull/368 where new make targets test and lint are introduced we are adding new presubmit jobs that execute them.
/hold to wait for above PR to land /wg code-quality
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
@aburdenthehand: GitHub didn't allow me to request PR reviews from the following users: for.
Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @EdDev for wg-code-quality
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dhiller: The /test command needs one or more targets.
The following commands are available to trigger required jobs:
/test build-autoowners-image/test build-bootstrap-image/test build-fedora-coreos-kubevirt-image/test build-kubekins-e2e-image/test build-kubevirt-infra-bootstrap-image/test build-kubevirt-kubevirt.github.io-image/test build-kubevirt-user-guide-image/test build-pr-creator-image/test build-prow-deploy-image/test build-release-tool-image/test build-shared-images-controller-image/test build-test-label-analyzer-image/test build-vm-image-builder-image/test check-prow-config/test pull-kubevirt-org-github-config-updater/test pull-project-infra-check-testgrid-config/test pull-project-infra-ci-search-deploy-test/test pull-project-infra-coverage/test pull-project-infra-grafana-deploy-test/test pull-project-infra-job-config-validator/test pull-project-infra-lint/test pull-project-infra-prow-deploy-test/test pull-project-infra-test-bazel-config/test pull-project-infra-test-external-plugins/test pull-project-infra-test-github-ci-services/test pull-project-infra-test-releng/test pull-project-infra-test-robots/test pull-prow-kubevirt-labels-update-precheck/test pull-prow-nmstate-labels-update-precheck
Use /test all to run the following jobs that were automatically triggered:
check-prow-configpull-project-infra-check-testgrid-configpull-project-infra-prow-deploy-test
In response to this:
/test pull-project-infra-lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@EdDev did you get a chance to look at this?
I just reviewed the PR that this one is dependent on. +1 to add the job once the other one is merged.
/lgtm
Since https://github.com/kubevirt/community/pull/368 has been merged we are good to merge this one also.
@brianmcarey would you mind taking a look?
Rehearsal jobs created for this PR:
rehearsal-pull-community-make-lint
rehearsal-pull-community-make-test
rehearsal-pull-community-make-coverage
A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.
A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.
Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.
A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.
Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.
[1]: see OWNERS file definition for reference.
@dhiller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| rehearsal-pull-community-make-lint | 1566acd41454d2b02fddcbcbb7af05904edfe4d8 | link | true | /test pull-community-make-lint |
| rehearsal-pull-community-make-coverage | 1566acd41454d2b02fddcbcbb7af05904edfe4d8 | link | true | /test pull-community-make-coverage |
| rehearsal-pull-community-make-test | 1566acd41454d2b02fddcbcbb7af05904edfe4d8 | link | true | /test pull-community-make-test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brianmcarey
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~github/ci/prow-deploy/files/jobs/kubevirt/community/OWNERS~~ [brianmcarey]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
As these jobs include project-infra - this breaks the rehearsal plugin. Overriding the rehearsal failures
/override rehearsal-pull-community-make-lint /override rehearsal-pull-community-make-coverage /override rehearsal-pull-community-make-test
@brianmcarey: Overrode contexts on behalf of brianmcarey: rehearsal-pull-community-make-coverage, rehearsal-pull-community-make-lint, rehearsal-pull-community-make-test
In response to this:
As these jobs include project-infra - this breaks the rehearsal plugin. Overriding the rehearsal failures
/override rehearsal-pull-community-make-lint /override rehearsal-pull-community-make-coverage /override rehearsal-pull-community-make-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:
- key
community-presubmits.yamlusing filegithub/ci/prow-deploy/files/jobs/kubevirt/community/community-presubmits.yaml
In response to this:
What this PR does / why we need it:
Based on PR https://github.com/kubevirt/community/pull/368 where new make targets test and lint are introduced we are adding new presubmit jobs that execute them.
/hold to wait for above PR to land /wg code-quality
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.