project-infra
project-infra copied to clipboard
kubevirt
bazel: move to vendoring go dependencies
What this PR does / why we need it:
Replaces the bazel dependency management for go repositories with pure go mod vendoring.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @brianmcarey
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
/cc @xpivarc
FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only.
Rehearsal is available for the following jobs in this PR:
pull-project-infra-test-robots
You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}.
For a list of jobs that you can rehearse you can comment /rehearse ?.
Rehearsal jobs created for this PR:
rehearsal-pull-project-infra-test-robots
You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}.
For a list of jobs that you can rehearse you can comment /rehearse ?.
/cc @xpivarc
FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only.
I like vendoring :+1:
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}.
For a list of jobs that you can rehearse you can comment /rehearse ?.
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}.
For a list of jobs that you can rehearse you can comment /rehearse ?.
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}.
For a list of jobs that you can rehearse you can comment /rehearse ?.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
/remove-lifecycle stale
@xpivarc this is the effort to move towards vendoring, which I talked about in today's sig-ci meeting
@dhiller: The following commands are available to trigger required jobs:
/test build-autoowners-image/test build-bootstrap-image/test build-fedora-coreos-kubevirt-image/test build-kubekins-e2e-image/test build-kubevirt-infra-bootstrap-image/test build-kubevirt-kubevirt.github.io-image/test build-kubevirt-user-guide-image/test build-pr-creator-image/test build-prow-deploy-image/test build-release-tool-image/test build-shared-images-controller-image/test build-test-label-analyzer-image/test build-vm-image-builder-image/test check-prow-config/test pull-kubevirt-org-github-config-updater/test pull-project-infra-check-testgrid-config/test pull-project-infra-ci-search-deploy-test/test pull-project-infra-grafana-deploy-test/test pull-project-infra-job-config-validator/test pull-project-infra-prow-deploy-test/test pull-project-infra-test-bazel-config/test pull-project-infra-test-external-plugins/test pull-project-infra-test-github-ci-services/test pull-project-infra-test-releng/test pull-project-infra-test-robots/test pull-prow-kubevirt-labels-update-precheck/test pull-prow-nmstate-labels-update-precheck
Use /test all to run the following jobs that were automatically triggered:
build-release-tool-imagebuild-shared-images-controller-imagebuild-test-label-analyzer-imagecheck-prow-configpull-project-infra-check-testgrid-configpull-project-infra-ci-search-deploy-testpull-project-infra-grafana-deploy-testpull-project-infra-job-config-validatorpull-project-infra-prow-deploy-testpull-project-infra-test-bazel-configpull-project-infra-test-external-pluginspull-project-infra-test-github-ci-servicespull-project-infra-test-relengpull-project-infra-test-robots
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test pull-project-infra-test-external-plugins /test pull-project-infra-test-releng /test pull-project-infra-test-robots
@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| rehearsal-pull-project-infra-test-robots | 588fdeedd9a0448e346a1821da9ba6f4c46aac91 | link | unknown | /test pull-project-infra-test-robots |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.