project-infra
project-infra copied to clipboard
release, verification: add gpg key setup to release job
What this PR does / why we need it:
Sets up the job for successfully signing the release source tarball by:
- mounting the gpg key to the job pod,
- setting the env var to the user-id of the key and
- importing the key ahead of signing.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @brianmcarey @xpivarc
See kubevirt/kubevirt#12228
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
/approve
@xpivarc would you mind taking a look at this?
@xpivarc is there anything left to do for me here?
/cc @brianmcarey can you take a look and approve?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: stu-gott, xpivarc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS~~ [stu-gott,xpivarc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:
- key
kubevirt-postsubmits.yamlusing filegithub/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-postsubmits.yaml
In response to this:
What this PR does / why we need it:
Sets up the job for successfully signing the release source tarball by:
- mounting the gpg key to the job pod,
- setting the env var to the user-id of the key and
- importing the key ahead of signing.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
/cc @brianmcarey @xpivarc
See kubevirt/kubevirt#12228
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.