project-infra icon indicating copy to clipboard operation
project-infra copied to clipboard

release, verification: add gpg key setup to release job

Open dhiller opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

Sets up the job for successfully signing the release source tarball by:

  • mounting the gpg key to the job pod,
  • setting the env var to the user-id of the key and
  • importing the key ahead of signing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @brianmcarey @xpivarc

See kubevirt/kubevirt#12228

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:


dhiller avatar Jun 27 '24 08:06 dhiller

/approve

stu-gott avatar Jul 18 '24 13:07 stu-gott

@xpivarc would you mind taking a look at this?

dhiller avatar Jul 22 '24 13:07 dhiller

@xpivarc is there anything left to do for me here?

dhiller avatar Aug 22 '24 13:08 dhiller

/cc @brianmcarey can you take a look and approve?

acardace avatar Aug 28 '24 06:08 acardace

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stu-gott, xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Aug 28 '24 07:08 kubevirt-bot

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-postsubmits.yaml

In response to this:

What this PR does / why we need it:

Sets up the job for successfully signing the release source tarball by:

  • mounting the gpg key to the job pod,
  • setting the env var to the user-id of the key and
  • importing the key ahead of signing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @brianmcarey @xpivarc

See kubevirt/kubevirt#12228

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot avatar Aug 28 '24 07:08 kubevirt-bot