project-infra
project-infra copied to clipboard
sigs, sync: extract sigs from OWNERS_ALIASES, create GitHub groups and labels for sigs
What this PR does / why we need it:
Adds a tool robots/cmd/sig-to-org-team-syncer that extracts the sigs and the sig members from a source OWNERS_ALIASES file, then adds or updates GitHub teams for SIGs in the target Peribolos configuration, and adds missing SIG labels in target label_sync configuration.
Also adds a postsubmit job that executes above mentioned tool and creates a pull request with the generated changes. Said job is triggered whenever the file OWNERS_ALIASES from repo kubevirt/kubevirt is modified.
Full example:
OWNERS_ALIASES from kubevirt/kubevirt contains:
...
sig-buildsystem-approvers:
dhiller
...
sig-buildsystem-reviewers:
dhiller
...
will create a GitHub team sig-buildsystem with privacy closed, whose members are all people from the above alias groups. Existing teams will be updated such that the missing GitHub handles will be added to the team.
That team can then be pinged on a PR with @kubevirt/sig-buildsystem
Also it will add a label sig/buildsystem that is then available for all pull requests.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @aburdenthehand @fabiand
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@aburdenthehand @fabiand since I didn't find any Kubernetes solution for this, I came up with a simple own one. WDYT?
/hold
I think I need to improve here - since the source of truth should be the sigs.yaml from k/community, we should extract the sigs from there, and then fetch the GitHub handles from the OWNERS_ALIASES which we then add to the GitHub teams. Also the label can be fetched from sigs.yaml - no need to extract it awkwardly from the OWNERS_ALIASES.
As a side note: we could also consider adding three teams, one for all reviewers and approvers and two other groups, containing only reviewers or only approvers.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Closing due to lack of interest :confused:
/close
@dhiller: Closed this PR.
In response to this:
Closing due to lack of interest :confused:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.