kubevirtci
kubevirtci copied to clipboard
kubevirt
kubevirtci, cluster-up: move cluster spin up logic into gocli
We currently have the logic of spinning up a KubeVirtCI cluster inside the cluster-up folder of kubevirt/kubevirtci.
This is sourced into kubevirt/kubevirt. An update of kubevirtci updates the sourced folder. Other users of kubevirtci clone the repo on the fly.
Let's move all the logic of cluster-up into gocli, this way we only need to update the tag of the gocli image for a cluster update.
It sounds good to me, I see less and less value in having it. (revering to the cluster-up folder)
@dhiller: This request has been marked as suitable for new contributors.
Guidelines
- No Barrier to Entry
- Clear Task
- Solution Explained
- Provides Context
- Identifies Relevant Code
- Gives Examples
- Ready to Test
- Goldilocks priority
- Up-To-Date
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
FYI @brianmcarey
/good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Please note there is kind-sriov provider which all its logic is on cluster-up folder bash scripts
imho it isn't "good first issue"
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
@dhiller @brianmcarey Please note that @aerosouund is working on https://github.com/kubevirt/community/issues/257. First PR in series would be https://github.com/kubevirt/kubevirtci/pull/1209.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@brianmcarey: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dhiller: Reopened this issue.
In response to this:
/remove-lifecycle rotten /reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.