kubevirt icon indicating copy to clipboard operation
kubevirt copied to clipboard

Published 20 hours ago • verified publisher icon kubevirt

code cleanup: Use libvmi builder pattern instead of NewRandomVMI function

Open Barakmor1 opened this issue 2 years ago • 15 comments

Add options to libvmi in order to use libvmi builder pattern in functional tests instead of NewRandomVMI functions. What this PR does / why we need it: Using libvmi instead of NewRandomVMI functions. Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE

Barakmor1 avatar Jul 11 '22 08:07 Barakmor1

/sig code-quality

Barakmor1 avatar Jul 11 '22 08:07 Barakmor1

@Barakmor1 can you please change the PR title to something like Add libvmi options for CPU resources, SerialBIOS and ClientPassthrough?

iholder101 avatar Jul 11 '22 10:07 iholder101

/retest

Barakmor1 avatar Jul 11 '22 14:07 Barakmor1

/lgtm

iholder101 avatar Jul 12 '22 10:07 iholder101

/retest

Barakmor1 avatar Jul 14 '22 09:07 Barakmor1

@dankenigsberg @xpivarc Removed the new Option and created local function instead.

Barakmor1 avatar Jul 17 '22 09:07 Barakmor1

/retest

Barakmor1 avatar Jul 18 '22 09:07 Barakmor1

/retest

Barakmor1 avatar Jul 18 '22 11:07 Barakmor1

/retest

Barakmor1 avatar Jul 18 '22 13:07 Barakmor1

/retest-required

Barakmor1 avatar Jul 25 '22 07:07 Barakmor1

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot avatar Aug 07 '22 11:08 kubevirt-commenter-bot

Hey @dankenigsberg , I had to rebase. Can you have another look please ?

Barakmor1 avatar Aug 08 '22 07:08 Barakmor1

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Aug 17 '22 07:08 kubevirt-bot

Thanks @Barakmor1! /lgtm

iholder101 avatar Aug 24 '22 14:08 iholder101

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot avatar Aug 24 '22 22:08 kubevirt-commenter-bot

@Barakmor1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa 1d1ca9812de39f854e3e5ea8b753d7f3ec49d770 link false /test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubevirt-bot avatar Aug 24 '22 23:08 kubevirt-bot

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot avatar Aug 25 '22 04:08 kubevirt-commenter-bot