kubevirt
kubevirt copied to clipboard
kubevirt
refactor: replace all the datavolumes and pvcs name
replace all the datavolumes and pvcs name assignements with PVCNameFromVirtVolume
What this PR does
Fixes #11254
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Thank you for reviewing
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note
None
Hi @sarthaksarthak9. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@sarthaksarthak9 please, adjust your commit message. Right now, you have the sign-off as title.
Please, give a short title and then a quick description of what the commit does.
You can add the signoff using git commit -s and you can use git commit --amend -s to modify the latest commit.
@sarthaksarthak9 can you please fix the commit message with a short title and a brief explanation why the change is needed
@sarthaksarthak9 please, give a short title and a message body in the commit message. Try to give a look to the git history with git log to standardize your commit message.
@sarthaksarthak9 please, give a short title and a message body in the commit message. Try to give a look to the git history with
git logto standardize your commit message.
@alicefr Srry I am quite confuse rn, I try to did something similar "Refactor: Replaces data volume and PVC name assignments with PVCNameFromVirtVolume function".
@sarthaksarthak9
Please take a look at this: https://cbea.ms/git-commit/ The first line is usually a short log, to provide quick context. The body of the commit log provides further context and material needed. This is super helpful when you have to look at hundreds of commits or even better understands the changes thanks to the author's context.
Thanks for working on this.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xpivarc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/storage/OWNERS~~ [xpivarc]
- ~~pkg/virt-handler/OWNERS~~ [xpivarc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Required labels detected, running phase 2 presubmits: /test pull-kubevirt-e2e-windows2016 /test pull-kubevirt-e2e-kind-1.27-vgpu /test pull-kubevirt-e2e-kind-sriov /test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network /test pull-kubevirt-e2e-k8s-1.27-sig-network /test pull-kubevirt-e2e-k8s-1.27-sig-storage /test pull-kubevirt-e2e-k8s-1.27-sig-compute /test pull-kubevirt-e2e-k8s-1.27-sig-operator /test pull-kubevirt-e2e-k8s-1.28-sig-network /test pull-kubevirt-e2e-k8s-1.28-sig-storage /test pull-kubevirt-e2e-k8s-1.28-sig-compute /test pull-kubevirt-e2e-k8s-1.28-sig-operator
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.