kubevirt.github.io
kubevirt.github.io copied to clipboard
kubevirt
Fix shell's expansion of `VERSION` in deploy command
What this PR does / why we need it:
This PR fixes the improper interpolation of the "VERSION" variable within the URL string in the kubectl create command. This is because the curly braces {} are not being interpreted correctly in the URL as when they are pasted in other shells like zsh, escape is inserted around { & }.
To fix this, we need to use double quotes for the URL string in the kubectl create command.
Does this PR fix any issue? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #934
Special notes for your reviewer:
Hi @aktech. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@brianmcarey @jean-edouard Are you able to take a look at this please?
Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.
After that period the bot marks them with the label needs-approver-review.
/label needs-approver-review
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aburdenthehand
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [aburdenthehand]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment