kubevirt.github.io icon indicating copy to clipboard operation
kubevirt.github.io copied to clipboard
verified publisher icon kubevirt

Review and update of lab1

Open seb54000 opened this issue 2 years ago • 4 comments

What this PR does / why we need it: Review the lab1 tutorial, verify it is still working and add some details about vm / vmi difference

Does this PR fix any issue? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #938

Special notes for your reviewer: THis is part fo the Kubecon 2024 Paris Contribfest

seb54000 avatar Mar 22 '24 16:03 seb54000

Hi @seb54000. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Mar 22 '24 16:03 kubevirt-bot

Thanks a lot @aburdenthehand , it was a real pleasure meeting you and all other Kubevirt contributors. Your proposal of modifications are perfect, I will include them and solve this signing issue hopefully through squashing.

seb54000 avatar Mar 28 '24 21:03 seb54000

@aburdenthehand PTAL

xpivarc avatar Apr 02 '24 09:04 xpivarc

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot avatar Jul 01 '24 10:07 kubevirt-bot

/remove-lifecycle stale @tiraboschi Does it make sense to merge this so that the lab is updated and this work is not lost and then subsequently include the logging improvement?

aburdenthehand avatar Jul 08 '24 11:07 aburdenthehand

/approve I haven't heard back from @tiraboschi but I would rather one improvement be merged followed by a possible second rather than risk having no improvements :) @brianmcarey PTAL?

aburdenthehand avatar Jul 29 '24 11:07 aburdenthehand

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Jul 29 '24 11:07 kubevirt-bot