hyperconverged-cluster-operator icon indicating copy to clipboard operation
hyperconverged-cluster-operator copied to clipboard

Revert "hack: add a workaround for DataVolume GC on CDI v1.55.0"

Open tiraboschi opened this issue 1 year ago • 15 comments

This reverts commit 3cfc1289eca676d9ae234c8ec2d9f02ddb991133.

workaround for DataVolume GC on CDI v1.55.0: kubevirt/kubevirt#8584 didn't landed in Kubevirt v0.58.0, TODO: remove this once kubevirt/kubevirt#8584 will land in Kubevirt v0.58.1

Signed-off-by: Simone Tiraboschi [email protected]

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • [ ] PR Message
  • [ ] Commit Messages
  • [ ] How to test
  • [ ] Unit Tests
  • [ ] Functional Tests
  • [ ] User Documentation
  • [ ] Developer Documentation
  • [ ] Upgrade Scenario
  • [ ] Uninstallation Scenario
  • [ ] Backward Compatibility
  • [ ] Troubleshooting Friendly

Release note:

NONE

tiraboschi avatar Oct 18 '22 16:10 tiraboschi

Pull Request Test Coverage Report for Build 3409898170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.419%

Totals Coverage Status
Change from base Build 3396651808: 0.0%
Covered Lines: 4634
Relevant Lines: 5425

💛 - Coveralls

coveralls avatar Oct 18 '22 16:10 coveralls

okd-hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-gcp

hco-bot avatar Oct 18 '22 18:10 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Oct 18 '22 18:10 kubevirt-bot

hco-e2e-image-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-image-index-sno-aws hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-azure

hco-bot avatar Oct 18 '22 18:10 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-image-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-image-index-sno-aws hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Oct 18 '22 18:10 kubevirt-bot

/cherry-pick release-1.8

tiraboschi avatar Oct 21 '22 06:10 tiraboschi

@tiraboschi: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Oct 21 '22 06:10 kubevirt-bot

/rebase

tiraboschi avatar Oct 24 '22 07:10 tiraboschi

hco-e2e-image-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-image-index-sno-aws hco-e2e-upgrade-index-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-index-aws

hco-bot avatar Oct 24 '22 09:10 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-image-index-sno-aws hco-e2e-upgrade-index-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Oct 24 '22 09:10 kubevirt-bot

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded. /override ci/prow/hco-e2e-image-index-azure

hco-bot avatar Oct 24 '22 10:10 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded. /override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Oct 24 '22 10:10 kubevirt-bot

/rebase

tiraboschi avatar Nov 07 '22 11:11 tiraboschi

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Nov 07 '22 11:11 sonarcloud[bot]

/cherry-pick release-1.8

tiraboschi avatar Nov 07 '22 11:11 tiraboschi

@tiraboschi: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Nov 07 '22 11:11 kubevirt-bot

hco-e2e-image-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-image-index-sno-azure okd-hco-e2e-image-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-image-index-aws

hco-bot avatar Nov 07 '22 13:11 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/okd-hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-image-index-sno-azure okd-hco-e2e-image-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Nov 07 '22 13:11 kubevirt-bot

hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-azure hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure hco-e2e-upgrade-prev-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

hco-bot avatar Nov 07 '22 14:11 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-azure hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure hco-e2e-upgrade-prev-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Nov 07 '22 14:11 kubevirt-bot

hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded. /override ci/prow/hco-e2e-image-index-azure

hco-bot avatar Nov 07 '22 14:11 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded. /override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Nov 07 '22 14:11 kubevirt-bot

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-hco-e2e-image-index-aws 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link true /test okd-hco-e2e-image-index-aws
ci/prow/hco-e2e-image-index-sno-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link false /test hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-sno-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link false /test hco-e2e-upgrade-prev-index-sno-azure
ci/prow/hco-e2e-upgrade-index-sno-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link false /test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-upgrade-index-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link true /test hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-image-index-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link true /test hco-e2e-image-index-azure
ci/prow/hco-e2e-upgrade-prev-index-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-kv-smoke-azure 08529a90d5bf4927b2a196e5e5ff5cab443c6cdc link true /test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 07 '22 15:11 openshift-ci[bot]

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

hco-bot avatar Nov 07 '22 15:11 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Nov 07 '22 15:11 kubevirt-bot

/lgtm /approve

machadovilaca avatar Nov 08 '22 13:11 machadovilaca

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machadovilaca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Nov 08 '22 13:11 kubevirt-bot

@tiraboschi: new pull request created: #2137

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Nov 08 '22 13:11 kubevirt-bot