hyperconverged-cluster-operator icon indicating copy to clipboard operation
hyperconverged-cluster-operator copied to clipboard

Published 20 hours ago • verified publisher icon kubevirt

Consume ConsolePlugin API as v1

Open tiraboschi opened this issue 2 years ago • 6 comments

In OCP/OKD 4.12, the ConsolePlugin API got promoted from v1alpha1 to v1. See: https://github.com/openshift/api/pull/1186

Consume the new version.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2133735

Signed-off-by: Simone Tiraboschi [email protected]

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • [ ] PR Message
  • [ ] Commit Messages
  • [ ] How to test
  • [ ] Unit Tests
  • [ ] Functional Tests
  • [ ] User Documentation
  • [ ] Developer Documentation
  • [ ] Upgrade Scenario
  • [ ] Uninstallation Scenario
  • [ ] Backward Compatibility
  • [ ] Troubleshooting Friendly

Release note:

Consume ConsolePlugin API as v1

tiraboschi avatar Oct 11 '22 09:10 tiraboschi

Pull Request Test Coverage Report for Build 3831084774

  • 14 of 20 (70.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 85.542%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/util.go 0 6 0.0%
<!-- Total: 14 20
Files with Coverage Reduction New Missed Lines %
pkg/util/util.go 1 51.5%
<!-- Total: 1
Totals Coverage Status
Change from base Build 3830659052: -0.07%
Covered Lines: 4692
Relevant Lines: 5485
💛 - Coveralls

coveralls avatar Oct 11 '22 09:10 coveralls

/hold this is not going to work for OKD 4.11

tiraboschi avatar Oct 11 '22 13:10 tiraboschi

/rebase

tiraboschi avatar Oct 24 '22 07:10 tiraboschi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tiraboschi by writing /assign @tiraboschi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Oct 24 '22 07:10 kubevirt-bot

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 24 '22 07:10 sonarqubecloud[bot]

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-hco-e2e-upgrade-index-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test okd-hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-upgrade-index-sno-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link false /test hco-e2e-upgrade-index-sno-aws
ci/prow/hco-e2e-upgrade-index-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-upgrade-index-aws
ci/prow/hco-e2e-upgrade-prev-index-sno-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link false /test hco-e2e-upgrade-prev-index-sno-aws
ci/prow/okd-hco-e2e-image-index-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test okd-hco-e2e-image-index-aws
ci/prow/hco-e2e-upgrade-prev-index-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-upgrade-prev-index-aws
ci/prow/hco-e2e-image-index-sno-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link false /test hco-e2e-image-index-sno-aws
ci/prow/okd-hco-e2e-upgrade-index-gcp 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test okd-hco-e2e-upgrade-index-gcp
ci/prow/hco-e2e-image-index-aws 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-image-index-aws
ci/prow/hco-e2e-kv-smoke-gcp 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-kv-smoke-gcp
ci/prow/okd-hco-e2e-image-index-gcp 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-gcp 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-sno-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link false /test hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-sno-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link false /test hco-e2e-upgrade-prev-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-upgrade-index-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-upgrade-index-sno-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link false /test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-image-index-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-image-index-azure
ci/prow/hco-e2e-kv-smoke-azure 67990df71a538f9b3908b73ac5e91ef9e084b59b link true /test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 24 '22 10:10 openshift-ci[bot]

/rebase

orenc1 avatar Nov 14 '22 19:11 orenc1

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 14 '22 19:11 sonarqubecloud[bot]

/override-bot

tiraboschi avatar Dec 19 '22 21:12 tiraboschi

/retest

tiraboschi avatar Dec 20 '22 08:12 tiraboschi

/unhold

tiraboschi avatar Jan 03 '23 16:01 tiraboschi

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 03 '23 16:01 sonarqubecloud[bot]

hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-azure

hco-bot avatar Jan 03 '23 17:01 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 03 '23 17:01 kubevirt-bot

okd-hco-e2e-image-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-image-index-aws

hco-bot avatar Jan 03 '23 17:01 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-aws

In response to this:

okd-hco-e2e-image-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 03 '23 17:01 kubevirt-bot

hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure

hco-bot avatar Jan 03 '23 18:01 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 03 '23 18:01 kubevirt-bot

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-kv-smoke-azure 7ccb1de3aa4135895df93da23fb735013be6b446 link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-upgrade-index-sno-azure 7ccb1de3aa4135895df93da23fb735013be6b446 link false /test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-upgrade-prev-index-azure 7ccb1de3aa4135895df93da23fb735013be6b446 link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-image-index-aws 7ccb1de3aa4135895df93da23fb735013be6b446 link true /test hco-e2e-image-index-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 03 '23 18:01 openshift-ci[bot]

hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded. /override ci/prow/hco-e2e-image-index-aws

hco-bot avatar Jan 03 '23 18:01 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded. /override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 03 '23 18:01 kubevirt-bot

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

hco-bot avatar Jan 03 '23 19:01 hco-bot

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 03 '23 19:01 kubevirt-bot

ignoring slightly decreased coverage /override coverage/coveralls

tiraboschi avatar Jan 03 '23 19:01 tiraboschi

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

ignoring slightly decreased coverage /override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot avatar Jan 03 '23 19:01 kubevirt-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Jan 04 '23 06:01 kubevirt-bot

:rocket: :partying_face:

nunnatsa avatar Jan 04 '23 06:01 nunnatsa