hyperconverged-cluster-operator
hyperconverged-cluster-operator copied to clipboard
kubevirt
WIP: avoid creating and watching kubevirt priorityclass
Starting with v0.16.0, OLM is able to directly manage priority classes shipped in the bundle image. See: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/adding-priority-classes.md
Signed-off-by: Simone Tiraboschi [email protected]
Reviewer Checklist
Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.
- [ ] PR Message
- [ ] Commit Messages
- [ ] How to test
- [ ] Unit Tests
- [ ] Functional Tests
- [ ] User Documentation
- [ ] Developer Documentation
- [ ] Upgrade Scenario
- [ ] Uninstallation Scenario
- [ ] Backward Compatibility
- [ ] Troubleshooting Friendly
Release note:
@tiraboschi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tiraboschi by writing /assign @tiraboschi in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Pull Request Test Coverage Report for Build 3190573506
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 5 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.2%) to 85.171%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| controllers/operands/operand.go | 5 | 79.1% |
| <!-- | Total: | 5 |
| Totals | |
|---|---|
| Change from base Build 3187925639: | -0.2% |
| Covered Lines: | 4549 |
| Relevant Lines: | 5341 |
💛 - Coveralls
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-hyperconverged-cluster-operator-e2e-k8s-1.24 | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test pull-hyperconverged-cluster-operator-e2e-k8s-1.24 |
| pull-hyperconverged-cluster-operator-e2e-k8s-1.23 | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test pull-hyperconverged-cluster-operator-e2e-k8s-1.23 |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
okd-hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-gcp hco-e2e-upgrade-prev-index-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp
In response to this:
okd-hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-gcp hco-e2e-upgrade-prev-index-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/hold as for bug https://issues.redhat.com/browse/OCPBUGS-2068 , the OLM is not going to watch and reconcile the priority class after the initial deployment deployment so this is going to be a loss in terms of features and robustness of our operator.
@tiraboschi: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/hco-e2e-upgrade-prev-index-aws | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test hco-e2e-upgrade-prev-index-aws |
| ci/prow/okd-hco-e2e-image-index-aws | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test okd-hco-e2e-image-index-aws |
| ci/prow/okd-hco-e2e-upgrade-index-gcp | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test okd-hco-e2e-upgrade-index-gcp |
| ci/prow/hco-e2e-image-index-sno-aws | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | false | /test hco-e2e-image-index-sno-aws |
| ci/prow/okd-hco-e2e-image-index-gcp | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test okd-hco-e2e-image-index-gcp |
| ci/prow/hco-e2e-image-index-gcp | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test hco-e2e-image-index-gcp |
| ci/prow/hco-e2e-image-index-azure | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test hco-e2e-image-index-azure |
| ci/prow/hco-e2e-image-index-sno-azure | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | false | /test hco-e2e-image-index-sno-azure |
| ci/prow/hco-e2e-image-index-aws | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test hco-e2e-image-index-aws |
| ci/prow/okd-ci-index-hco-bundle | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test okd-ci-index-hco-bundle |
| ci/prow/ci-index-hco-bundle | 30a640685ef61059c280330e5b6fb6d070e1abcf | link | true | /test ci-index-hco-bundle |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale