hyperconverged-cluster-operator
hyperconverged-cluster-operator copied to clipboard
kubevirt
Don't increase the overwrittenModifications metric during upgrade
Some of the underline custom resources are getting changed as part of the upgrade process.
This causes HCO to increase the overwrittenModifications metric, while this is not a user
action.
This PR changes this behaviour to not increase the metric during upgrade, and so changes made during upgrade are not count.
Also, added some clean code in separate commits.
None
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull Request Test Coverage Report for Build 2970471921
- 6 of 12 (50.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.02%) to 84.952%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| controllers/operands/operandHandler.go | 2 | 8 | 25.0% |
| <!-- | Total: | 6 | 12 |
| Totals | |
|---|---|
| Change from base Build 2948514166: | -0.02% |
| Covered Lines: | 4460 |
| Relevant Lines: | 5250 |
💛 - Coveralls
hco-e2e-image-index-azure lane succeeded. /override ci/prow/hco-e2e-image-index-gcp hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-azure
In response to this:
hco-e2e-image-index-azure lane succeeded. /override ci/prow/hco-e2e-image-index-gcp hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-image-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-image-index-sno-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws
In response to this:
hco-e2e-image-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-image-index-sno-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tiraboschi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [tiraboschi]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls
In response to this:
/override coverage/coveralls ignoring slightly decreased coverage
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/hco-e2e-upgrade-index-sno-azure | e290a897d96e3ddc32243efe11ddfd6f519529fb | link | false | /test hco-e2e-upgrade-index-sno-azure |
| ci/prow/hco-e2e-upgrade-prev-index-azure | e290a897d96e3ddc32243efe11ddfd6f519529fb | link | true | /test hco-e2e-upgrade-prev-index-azure |
| ci/prow/hco-e2e-image-index-gcp | e290a897d96e3ddc32243efe11ddfd6f519529fb | link | true | /test hco-e2e-image-index-gcp |
| ci/prow/hco-e2e-image-index-sno-aws | e290a897d96e3ddc32243efe11ddfd6f519529fb | link | false | /test hco-e2e-image-index-sno-aws |
| ci/prow/hco-e2e-kv-smoke-azure | e290a897d96e3ddc32243efe11ddfd6f519529fb | link | true | /test hco-e2e-kv-smoke-azure |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure
In response to this:
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.