hostpath-provisioner icon indicating copy to clipboard operation
hostpath-provisioner copied to clipboard
verified publisher icon kubevirt

Fix runbook_url test

Open assafad opened this issue 1 year ago • 5 comments

What this PR does / why we need it: Fix runbook_url test to not expect the alert name as the URL suffix, as in some installations the alert name is not the URL suffix. e.g. in openshift the runbooks are in https://github.com/openshift/runbooks/tree/master/alerts/openshift-virtualization-operator, and the suffix is <alert-name>.md.

Release note:

None

assafad avatar Jul 21 '24 09:07 assafad

/lgtm

avlitman avatar Jul 21 '24 09:07 avlitman

cc @akalenyu, @awels

assafad avatar Jul 23 '24 10:07 assafad

@akalenyu can you please approve?

assafad avatar Jul 30 '24 07:07 assafad

/lgtm /cc @awels

akalenyu avatar Jul 30 '24 09:07 akalenyu

/approve

awels avatar Aug 08 '24 11:08 awels

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Aug 08 '24 11:08 kubevirt-bot