csi-driver
csi-driver copied to clipboard
kubevirt
Use CleanupMountPoint instead of Unmount in Unpublish
What this PR does / why we need it: Let's align with other drivers with benefiting from the years of experience accumulated in this API instead of directly calling Unmount
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Related to https://issues.redhat.com/browse/CNV-71540
Special notes for your reviewer:
Release note:
BugFix: corrupted mounts and more operations are handled more gracefully using the CleanupMountPoint API instead of directly calling Unmount
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign aglitke for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@akalenyu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-csi-driver-sanity-test | 8ad86d09cd5aba0e460b4d1a705f2bb7e64b18cd | link | true | /test pull-csi-driver-sanity-test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.