csi-driver icon indicating copy to clipboard operation
csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubevirt

Disable serviceLinks

Open kvaps opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

This PR disables mapping of kubernetes services into container environments

Which issue(s) this PR fixes

Fixes https://github.com/kubevirt/csi-driver/issues/120

Special notes for your reviewer:

Release note:

Disable serviceLinks in example manifests

kvaps avatar Oct 09 '24 15:10 kvaps

/assign @awels

kvaps avatar Oct 09 '24 15:10 kvaps

/lgtm /approve

awels avatar Oct 09 '24 16:10 awels

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Oct 09 '24 16:10 kubevirt-bot

/retest-required

awels avatar Nov 12 '24 20:11 awels

Looks like the tests are failing after disabling the service links. Might have to fix the tests.

awels avatar Nov 22 '24 16:11 awels

/retest-required

kvaps avatar Nov 25 '24 09:11 kvaps

So turns out that one of the tests was broken, we fixed that in https://github.com/kubevirt/csi-driver/pull/125 if you could rebase on top of that we can get this in.

awels avatar Jan 30 '25 17:01 awels

/retest

awels avatar Jan 30 '25 18:01 awels

/test pull-csi-driver-split-e2e-k8s

awels avatar Jan 30 '25 19:01 awels

/test pull-csi-driver-split-e2e-k8s

awels avatar Jan 30 '25 19:01 awels